Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.1.0 #3

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Release/0.1.0 #3

merged 3 commits into from
Dec 12, 2023
+2,685 −2

Conversation

adatzer
Copy link
Contributor

@adatzer adatzer commented Nov 8, 2023 •
edited
Loading

Todo:

  • Test cd github workflow with an -rc release
  • Create docs page
  • Link to created page from metadata.yaml
  • Link to created page from README.md
  • Fixup additional commits

@adatzer adatzer requested review from jethron and igneel64 November 8, 2023 08:27
@adatzer adatzer force-pushed the release/0.1.0 branch 2 times, most recently from cd89f02 to a22da1f Compare November 8, 2023 17:14
jethron
jethron approved these changes Nov 9, 2023
View reviewed changes
Copy link

@jethron jethron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work as always!

README.md Outdated Show resolved Hide resolved
template.tpl Outdated Show resolved Hide resolved
template.tpl Outdated Show resolved Hide resolved
template.tpl Outdated Show resolved Hide resolved
template.tpl Outdated Show resolved Hide resolved
template.tpl Outdated Show resolved Hide resolved
@adatzer
Copy link
Contributor Author

adatzer commented Nov 13, 2023

Thank you very much for reviewing @jethron !
Loved the idea to allow selecting the ecommerce function from a lookup table!
Also hardcoded the global name. You are right, it does not really worth making it configurable here.
I applied the changes based on your comments into additional commits (to be rebased before merging).

@adatzer adatzer merged commit e2b4d42 into main Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jethron jethron jethron approved these changes

@igneel64 igneel64 Awaiting requested review from igneel64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adatzer @jethron